Merged
Conversation
59c7467 to
2531fff
Compare
Collaborator
|
Integration test results for 2531fff: fail 😕 |
2531fff to
a66735e
Compare
Collaborator
|
Integration test results for a66735e: success 🎉 |
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
a66735e to
807e73d
Compare
Collaborator
|
Integration test results for 807e73d: fail 😕 |
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
Collaborator
|
Integration test results for 5d58400: success 🎉 |
alpeb
approved these changes
Apr 1, 2019
Member
alpeb
left a comment
There was a problem hiding this comment.
Changes looks great, and works perfectly, thanks! 🚢 
👕
Running test [install_test.go] --proxy-auto-inject
=== RUN TestVersionPreInstall
--- PASS: TestVersionPreInstall (0.04s)
=== RUN TestCheckPreInstall
--- PASS: TestCheckPreInstall (0.10s)
=== RUN TestInstall
--- PASS: TestInstall (35.35s)
=== RUN TestVersionPostInstall
--- PASS: TestVersionPostInstall (0.03s)
=== RUN TestInstallSP
--- PASS: TestInstallSP (0.16s)
=== RUN TestCheckPostInstall
--- PASS: TestCheckPostInstall (0.11s)
=== RUN TestDashboard
--- PASS: TestDashboard (0.56s)
=== RUN TestInject
--- PASS: TestInject (12.23s)
=== RUN TestServiceProfileDeploy
--- PASS: TestServiceProfileDeploy (0.58s)
=== RUN TestCheckProxy
--- PASS: TestCheckProxy (0.13s)
=== RUN TestLogs
--- PASS: TestLogs (30.02s)
=== RUN TestRestarts
--- PASS: TestRestarts (0.08s)
PASS
ok command-line-arguments 79.419s
KatherineMelnyk
pushed a commit
to KatherineMelnyk/linkerd2
that referenced
this pull request
Apr 5, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of linkerd#2569 Signed-off-by: Andrew Seigner <siggy@buoyant.io> Signed-off-by: kattymelnyk@gmail.com <kattymelnyk@gmail.com>
KatherineMelnyk
pushed a commit
to KatherineMelnyk/linkerd2
that referenced
this pull request
Apr 5, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of linkerd#2569 Signed-off-by: Andrew Seigner <siggy@buoyant.io> Signed-off-by: kattymelnyk@gmail.com <kattymelnyk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests were not exercising proxy auto inject.
Introduce a
--proxy-auto-injectflag toinstall_test.go, whichexercises install, check, and app deploy (via smoke test) for both
manual and auto injected use cases.
Part of #2569
Signed-off-by: Andrew Seigner siggy@buoyant.io