Merged
Conversation
The linkerd check command organized the various checks via loosely coupled category IDs, category names, and checkers themselves, all with ordering defined by consumers of this code. This change removes category IDs in favor of category names, groups all checkers by category, and enforces ordering at the HealthChecker level. Part of #1471, depends on #2078. Signed-off-by: Andrew Seigner <siggy@buoyant.io>
klingerf
approved these changes
Jan 15, 2019
Contributor
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Huge improvement! This is awesome.
pkg/healthcheck/healthcheck.go
Outdated
| }, | ||
| }, | ||
| { | ||
| description: fmt.Sprintf("can create %ss", "ClusterRole"), |
Contributor
There was a problem hiding this comment.
Since there's no variable anymore, you can write this as:
Suggested change
| description: fmt.Sprintf("can create %ss", "ClusterRole"), | |
| description: "can create ClusterRoles", |
pkg/healthcheck/healthcheck.go
Outdated
| }, | ||
| }, | ||
| { | ||
| description: fmt.Sprintf("can create %ss", "ClusterRoleBinding"), |
Contributor
There was a problem hiding this comment.
Suggested change
| description: fmt.Sprintf("can create %ss", "ClusterRoleBinding"), | |
| description: "can create ClusterRoleBindings", |
pkg/healthcheck/healthcheck.go
Outdated
| }, | ||
| }, | ||
| { | ||
| description: fmt.Sprintf("can create %ss", "Role"), |
Contributor
There was a problem hiding this comment.
Suggested change
| description: fmt.Sprintf("can create %ss", "Role"), | |
| description: "can create Roles", |
pkg/healthcheck/healthcheck.go
Outdated
| }, | ||
| }, | ||
| { | ||
| description: fmt.Sprintf("can create %ss", "RoleBinding"), |
Contributor
There was a problem hiding this comment.
Suggested change
| description: fmt.Sprintf("can create %ss", "RoleBinding"), | |
| description: "can create RoleBindings", |
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linkerd check command organized the various checks via loosely
coupled category IDs, category names, and checkers themselves, all with
ordering defined by consumers of this code.
This change removes category IDs in favor of category names, groups all
checkers by category, and enforces ordering at the HealthChecker
level.
Part of #1471, depends on #2078.
Signed-off-by: Andrew Seigner siggy@buoyant.io