add trust_dns=error to default proxy log level#10774
Merged
Conversation
Since upstream has yet to release a version with PR bluejekyll/trust-dns#1881, this commit changes the proxy's default log level to silence warnings from `trust_dns_proto` that are generally spurious. Closes #10123.
Member
|
Looks good! I think you need to run |
adleong
approved these changes
Apr 18, 2023
alpeb
approved these changes
Apr 20, 2023
alpeb
pushed a commit
that referenced
this pull request
Apr 24, 2023
* add `trust_dns=error` to default proxy log level Since upstream has yet to release a version with PR bluejekyll/trust-dns#1881, this commit changes the proxy's default log level to silence warnings from `trust_dns_proto` that are generally spurious. Closes #10123.
risingspiral
pushed a commit
that referenced
this pull request
May 4, 2023
* add `trust_dns=error` to default proxy log level Since upstream has yet to release a version with PR bluejekyll/trust-dns#1881, this commit changes the proxy's default log level to silence warnings from `trust_dns_proto` that are generally spurious. Closes #10123.
risingspiral
pushed a commit
that referenced
this pull request
May 5, 2023
* add `trust_dns=error` to default proxy log level Since upstream has yet to release a version with PR bluejekyll/trust-dns#1881, this commit changes the proxy's default log level to silence warnings from `trust_dns_proto` that are generally spurious. Closes #10123. Signed-off-by: Eric Anderson <eric@buoyant.io>
risingspiral
pushed a commit
that referenced
this pull request
May 5, 2023
* add `trust_dns=error` to default proxy log level Since upstream has yet to release a version with PR bluejekyll/trust-dns#1881, this commit changes the proxy's default log level to silence warnings from `trust_dns_proto` that are generally spurious. Closes #10123. Signed-off-by: Eric Anderson <eric@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since upstream has yet to release a version with PR
https://github.com/bluejekyll/trust-dns/pull/1881, this commit changes the proxy's default log
level to silence warnings from
trust_dns_protothat are generallyspurious.
Closes #10123.