[LI-HOTFIX] KAFKA-9855 - return cached Structs for Schemas with no fields#77
Merged
Conversation
…elds TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
smccauliff
approved these changes
Apr 13, 2020
smccauliff
left a comment
There was a problem hiding this comment.
So this is like Collections.emptyList() but for Structs.
Author
|
there's a higher-hanging fruit of Structs where values are all primitives. in theory we could specialize a Struct to have values = int[] instead of Object[] and save a significant chunk of memory on wrappers, but i'll punt on that for later. |
andrewchoi5
approved these changes
Apr 13, 2020
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
that referenced
this pull request
Jun 17, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
that referenced
this pull request
Jun 17, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET =
LI_DESCERIPTION = committing to our fork until upstream picks this up
EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472)
Signed-off-by: radai-rosenblatt radai.rosenblatt@gmail.com