Skip to content

Try different encrypted bintray-related env variables for Travis#4

Merged
jonlee2 merged 1 commit into
linkedin:2.0-lifrom
jonlee2:ci
Mar 8, 2019
Merged

Try different encrypted bintray-related env variables for Travis#4
jonlee2 merged 1 commit into
linkedin:2.0-lifrom
jonlee2:ci

Conversation

@jonlee2

@jonlee2 jonlee2 commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

The initial ones failed for some reason.

@jonlee2 jonlee2 requested a review from hzxa21 March 8, 2019 21:17
@hzxa21

hzxa21 commented Mar 8, 2019

Copy link
Copy Markdown

@jonlee2 Can you try to re-run the build a second time to see whether the 2nd run still works?

@jonlee2

jonlee2 commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator Author

@jonlee2 Can you try to re-run the build a second time to see whether the 2nd run still works?

The problem is that these encrypted env variables are used only during deploy (i.e., publishing artifacts) and running another build on PR doesn't really test anything. Moreover, PR builds remove those encrypted env variables for security reasons. Based on my understanding, whether it works or not can be only determined after the PR gets submitted and a new release is created.

@hzxa21 hzxa21 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonlee2 Thanks for the clarification. Approved the PR.

@jonlee2 jonlee2 merged commit db14a38 into linkedin:2.0-li Mar 8, 2019
@jonlee2 jonlee2 deleted the ci branch March 8, 2019 22:17
xiowu0 pushed a commit that referenced this pull request Jun 11, 2019
… Travis (#4)

TICKET =
LI_DESCRIPTION =

Travis couldn't access one of the initially encrypted variables for some reason.

EXIT_CRITERIA = MANUAL ["describe exit criteria"]
xiowu0 pushed a commit that referenced this pull request Jul 17, 2019
TICKET =
LI_DESCRIPTION =

Add build changes to publish github LinkedIn Kafka artifacts to bintray (#1)
[NOTE] This is a temporary measure to publish artifacts until CI is properly set up to do the job automatically. Users are not expected to run this themselves.

Add changes for CI builds and publishing artifacts to bintray. (#2)
Travis will kick off a build and publish artifacts to bintray upon creating a tag in the "x.y.z.w" format.

Try different encrypted bintray-related env variables for Travis (#4)
Travis couldn't access one of the initially encrypted variables for some reason.

Set Bintray-related env variables via repository setting instead of in .travis.yml (#5)

Use the maven repo under the LinkedIn Bintray account to publish artifacts (#25)

EXIT_CRITERIA = MANUAL [""]
earlcoder added a commit that referenced this pull request Apr 28, 2026
bin/kafka-recommended-leader-election.sh ships in 3.6-li but invokes
kafka.admin.RecommendedLeaderElectionCommand which was lost in the
PR #538 squash, causing ClassNotFoundException on invocation.

Port from 3.0-li with three Kafka 3.6 API adjustments:
- AdminCommandFailedException + AdminOperationException moved from
  kafka.common / kafka.admin (Scala) to org.apache.kafka.server.common
  (Java in server-common module).
- CommandDefaultOptions + CommandLineUtils moved from kafka.utils
  (Scala) to org.apache.kafka.server.util (Java in server-common).
- CommandLineUtils.printHelpAndExitIfNeeded(opts, msg) renamed to
  maybePrintHelpOrVersion(opts, msg).

The Admin.electRecommendedLeaders() method, AdminClient/ForwardingAdmin/
NoOpAdminClient implementations, and the existing (currently @disabled)
RecommendedLeaderElectionTest are already in 3.6-li, so no other ports
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants