[LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push#106
Merged
Lincong merged 3 commits intoJan 5, 2021
Conversation
…pon below conditions. - Create/open a new pull request - Re-open a pull request - Edited/updated a pull request - Synchronized a pull request - Push to the 2.4-li branch - Push to 2.4-li-dev-* branch(es) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = N/A
yifangl
reviewed
Dec 24, 2020
Comment on lines
+22
to
+23
| push: | ||
| branches: |
There was a problem hiding this comment.
So this workflow will also be triggered when pushing to these branches. Is this the intended behavior? Or you want it to be triggered only on pull request?
Author
There was a problem hiding this comment.
Yes, I do intend to trigger this workflow whenever those branches are updated (a PR is merged to it or someone force push to it).
If we do not include the push event here, will the workflow be trigger when we merge a PR to any of those branches?
There was a problem hiding this comment.
Yeah, then you may want to change the name / description here:
"name: Pull Request Build and Test Workflow
Run this workflow every time a new pull request is created in the repository"
It looks like it will just happen during a PR creation.
Otherwise all look good to me.
There was a problem hiding this comment.
What's the reason for triggering the test workflow upon push events?
Author
There was a problem hiding this comment.
The motivation is that when we need to force-push to a branch, we hope to trigger this workflow too.
There was a problem hiding this comment.
IMO, we should never allow force push to an official branch such as 2.4-li.
Assuming there are no force-pushes, then it seems we don't need to trigger CI on regular push events.
I'd suggest we remove these, what do you think?
yifangl
approved these changes
Dec 24, 2020
Comment on lines
+22
to
+23
| push: | ||
| branches: |
There was a problem hiding this comment.
Yeah, then you may want to change the name / description here:
"name: Pull Request Build and Test Workflow
Run this workflow every time a new pull request is created in the repository"
It looks like it will just happen during a PR creation.
Otherwise all look good to me.
gitlw
reviewed
Dec 24, 2020
gitlw
reviewed
Dec 24, 2020
lmr3796
pushed a commit
that referenced
this pull request
Oct 6, 2021
This commit is a squash of: - [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106) - [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107) - [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108) - [LI-HOTFIX] Updating description of the CI flow (#114) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = N/A
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Oct 22, 2021
This commit is a squash of: - [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106) - [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107) - [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108) - [LI-HOTFIX] Updating description of the CI flow (linkedin#114) - Add rat to CI build to make it consistent with PR (linkedin#173) And partially picked up the rat set up from - Adding licence and rat check (linkedin#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Oct 22, 2021
This commit is a squash of: - [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106) - [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107) - [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108) - [LI-HOTFIX] Updating description of the CI flow (linkedin#114) - Add rat to CI build to make it consistent with PR (linkedin#173) And partially picked up the rat set up from - Adding licence and rat check (linkedin#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Oct 22, 2021
This commit is a squash of: - [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106) - [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107) - [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108) - [LI-HOTFIX] Updating description of the CI flow (linkedin#114) - Add rat to CI build to make it consistent with PR (linkedin#173) And partially picked up the rat set up from - Adding licence and rat check (linkedin#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796
pushed a commit
that referenced
this pull request
Oct 27, 2021
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108) - 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796
pushed a commit
that referenced
this pull request
Oct 28, 2021
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108) - 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Nov 19, 2021
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (linkedin#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (linkedin#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (linkedin#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796
pushed a commit
that referenced
this pull request
Jan 1, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Jun 2, 2022
This commit is a squash of: - 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106) - bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107) - 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108) - e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README - 883ece3 [LI-HOTFIX] Updating description of the CI flow (linkedin#114) - 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173) - 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs - 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (linkedin#195) And partially picked up the rat set up from - 66596f0 [LI-HOTFIX] Adding licence and rat check (linkedin#159) TICKET = N/A LI_DESCRIPTION = LIKAFKA-34202 EXIT_CRITERIA = When migrating off Github Actions for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Github Actions workflow to trigger build and test upon the below conditions.
Test: Created a PR to my own forked repo and observed that this workflow was triggered (link)TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = N/A