Loadbased Partition assigner not using topic level metrics to recognize partitions#876
Merged
vmaheshw merged 10 commits intolinkedin:masterfrom Dec 6, 2021
Merged
Conversation
Pull latest
added 2 commits
December 3, 2021 17:02
surajkn
previously approved these changes
Dec 6, 2021
...rver/src/main/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssigner.java
Show resolved
Hide resolved
| if (index > -1) { | ||
| topic = p.substring(0, index); | ||
| } | ||
| String topic = extractTopicFromPartition(p); |
Collaborator
There was a problem hiding this comment.
Probably not a issue but for my understanding.
Below (for unassigned partitions for loop) we check if a partition is present in partitinInfoMap and if not check if partition's topic is present in partitionInfoMap. Why dont we do it that way here?
Collaborator
Author
There was a problem hiding this comment.
We are doing it, see the default value. This loop is for the partitions already assigned. That's why it is of no value to update the map.
surajkn
approved these changes
Dec 6, 2021
shrinandthakkar
approved these changes
Dec 6, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…ze partitions (linkedin#876) The load based estimator is considering the topic level metrics, but the assigner code is not using the information to distribute the partitions. Fixing the code to derive the partition level metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load based estimator is considering the topic level metrics, but the assigner code is not using the information to distribute the partitions. Fixing the code to derive the partition level metrics.