Add alert metrics to identify that elastic task configurations require adjustment#860
Merged
vmaheshw merged 6 commits intolinkedin:masterfrom Oct 28, 2021
Merged
Add alert metrics to identify that elastic task configurations require adjustment#860vmaheshw merged 6 commits intolinkedin:masterfrom
vmaheshw merged 6 commits intolinkedin:masterfrom
Conversation
jzakaryan
previously approved these changes
Oct 27, 2021
Collaborator
jzakaryan
left a comment
There was a problem hiding this comment.
lgtm. Please address or ignore the nit comments as you see fit.
...ain/java/com/linkedin/datastream/server/assignment/LoadBasedPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/linkedin/datastream/server/assignment/StickyPartitionAssignmentStrategy.java
Show resolved
Hide resolved
shrinandthakkar
approved these changes
Oct 27, 2021
Collaborator
shrinandthakkar
left a comment
There was a problem hiding this comment.
looks good to me, just added one clarification comment for my understanding.
jzakaryan
approved these changes
Oct 27, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…e adjustment (linkedin#860) To support better debugging and alerting support, Adding a new metrics "numTasks". This metrics will be used to keep the history of how the numTasks were selected for each datastream. It is enabled when elasticTaskCount feature is enabled. Apart from this, when numTasks== maxTasks, with elasticTaskCount feature enabled, the metric elasticTaskConfigurationNeedAdjustment will be set. This will allow to setup alerting and fixing the configurations. When the task estimation based on partition count is enabled, he metric elasticTaskConfigurationNeedAdjustment will be set, if the partitions in the task exceeds partitionsPerTask. This will allow to setup alerting and fixing the configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support better debugging and alerting support, Adding a new metrics "numTasks". This metrics will be used to keep the history of how the numTasks were selected for each datastream. It is enabled when elasticTaskCount feature is enabled.
Apart from this, when numTasks== maxTasks, with elasticTaskCount feature enabled, the metric
elasticTaskConfigurationNeedAdjustmentwill be set. This will allow to setup alerting and fixing the configurations.When the task estimation based on partition count is enabled, he metric
elasticTaskConfigurationNeedAdjustmentwill be set, if the partitions in the task exceeds partitionsPerTask. This will allow to setup alerting and fixing the configurations.