Update the DatabaseChunkedReader to take the Connection as input rather than the DataSource#850
Merged
somandal merged 2 commits intolinkedin:masterfrom Aug 19, 2021
Merged
Conversation
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…er than the DataSource (linkedin#850)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
DatabaseChunkedReadertakes aDataSourceas input and calls itsgetConnection()function to obtain a connection to the DB. In the release resources code path, it does not clean up thisConnectionobject, and this is potentially a leak and should be closed. The way we use theDatabaseChunkedReaderin Oracle bootstrap is that we reuse the sameDataSourcefor seeding multiple tables. Thus we can potentially expect the Oracle bootstrap task to know when it no longer needs theConnectionobject and close it. This would require passing theConnectionobject to theDatabaseChunkedReaderinstead of theDataSource.Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md