Fix flaky stopping simultaneous datastream test#849
Merged
shrinandthakkar merged 1 commit intolinkedin:masterfrom Aug 18, 2021
Merged
Conversation
Collaborator
|
Please add a note in commit message to mention why the test was flaky or what you did to fix it. |
surajkn
reviewed
Aug 18, 2021
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Show resolved
Hide resolved
Collaborator
|
lgtm |
surajkn
approved these changes
Aug 18, 2021
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Shrinand Thakkar <sthakkar@sthakkar-mn1.linkedin.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The timeout of 100ms turned out to be a little less for the test to finish, so instead of increasing the timeout there, added a polling loop, which will poll every 100ms for 1 sec to check the status of the datastream after the execution of the test.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md