Datastream stop transition redesign#842
Merged
shrinandthakkar merged 1 commit intolinkedin:masterfrom Aug 10, 2021
Merged
Conversation
vmaheshw
requested changes
Jul 19, 2021
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Outdated
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Outdated
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Outdated
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Outdated
Show resolved
Hide resolved
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Outdated
Show resolved
Hide resolved
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Outdated
Show resolved
Hide resolved
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Show resolved
Hide resolved
vmaheshw
reviewed
Jul 28, 2021
...-server-restli/src/test/java/com/linkedin/datastream/server/dms/TestDatastreamResources.java
Outdated
Show resolved
Hide resolved
fdb8ebf to
9d21d39
Compare
vmaheshw
previously approved these changes
Aug 6, 2021
Collaborator
vmaheshw
left a comment
There was a problem hiding this comment.
Mostly LGTM except some nit picks.
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Show resolved
Hide resolved
6c142db to
6e6d764
Compare
8c6be41 to
04a4c20
Compare
vmaheshw
approved these changes
Aug 6, 2021
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Shrinand Thakkar <sthakkar@sthakkar-mn1.linkedin.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a new intermediate STOPPING state in the lifecycle of a datastream, which represents a transitioning state for the leader to calculate and generate a new reassignment when a stop request is issued. This blocking transitioning state would make sure that any updates made to the datastream are applied successfully if datastream is restarted with a stop and resume call with a 60-second timeout in between.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md