Publishing artifacts to JFrog#839
Merged
vmaheshw merged 5 commits intolinkedin:masterfrom Jun 23, 2021
Merged
Conversation
vmaheshw
reviewed
Jun 22, 2021
Collaborator
vmaheshw
left a comment
There was a problem hiding this comment.
- Add description to the PR.
- Please share your testing steps (You can use internal Jira ticket to show the testing.)
- Sorry, I'm not aware of this part: Share the command that needs to be used to publish an artifact. Who will have access to run the artifact creation command?
vmaheshw
previously approved these changes
Jun 22, 2021
Collaborator
vmaheshw
left a comment
There was a problem hiding this comment.
Some more questions on artifact:
a) How to find the artifacts ? Any webpage which has all the artifacts
b) How does the versioning works for these artifacts?
This information will be useful for everyone.
jzakaryan
previously approved these changes
Jun 22, 2021
Collaborator
jzakaryan
left a comment
There was a problem hiding this comment.
LGTM. It's worth clarifying the copyright year thing before checking this in.
jzakaryan
previously approved these changes
Jun 22, 2021
vmaheshw
reviewed
Jun 22, 2021
jzakaryan
approved these changes
Jun 22, 2021
vmaheshw
approved these changes
Jun 23, 2021
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
As bintray is deprecated, adding support for pushing Brooklin artifacts to JFrog simultaneously with bintray.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As bintray is deprecated, adding support for pushing Brooklin artifacts to JFrog simultaneously with bintray.
Running and Testing steps:
FAQs:
a) Command to publish artifacts
./gradlew artifactoryPublishb) How to find the artifacts? Any webpage which has all the artifacts
All the published artifacts can be found in the JFrog Brooklin repo at https://linkedin.jfrog.io/ui/repos/tree/General/brooklin
c) How does the versioning work for these artifacts?
We usually follow Semantic Versioning which is explained here, https://github.com/linkedin/brooklin/wiki/Developer-Guide. But along with that, we have to make sure that the newer version doesn't already exist in JFrog artifactory.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md