Skip to content

Enable keyword arguments for liger functional #400

Merged
ByronHsu merged 8 commits into
mainfrom
hpguo/functional_revamp
Nov 21, 2024
Merged

Enable keyword arguments for liger functional #400
ByronHsu merged 8 commits into
mainfrom
hpguo/functional_revamp

Conversation

@hongpeng-guo

@hongpeng-guo hongpeng-guo commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Summary

This PR enables the keyword arguments of liger functional #368.

  1. Warp the Liger Operator Functions (torch.autograd.Function) with an extra layer that can take key word arguments.
  2. For each of the liger functions, updating its unit test function test_{operator_name}.py::test_correctness_functional to reflect that keyword args can be accepted.

Testing Done

  • Hardware Type: A10G
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
@hongpeng-guo

Copy link
Copy Markdown
Contributor Author

cc @ByronHsu coming from #399, Made a new PR in the main repo the enable modal unit tests.

@ByronHsu

Copy link
Copy Markdown
Contributor

@hongpeng-guo let's bump the timeout to 15 mins for modal test

@ByronHsu

Copy link
Copy Markdown
Contributor

@app.function(gpu="A10G", mounts=[repo], timeout=60 * 10)

hongpeng-guo and others added 2 commits November 20, 2024 23:08
@ByronHsu ByronHsu merged commit 317ff43 into main Nov 21, 2024
@ByronHsu ByronHsu deleted the hpguo/functional_revamp branch November 21, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants