[1/2] Enable keyword arguments for liger functional#399
Closed
hongpeng-guo wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Contributor
Author
|
@ByronHsu I would like to split the functional revamp into two PRs. This is the first one that simply defines the kwarg functions, as well as the unit test. The next PR will try to apply these functions to monkey patch the transformers. |
Contributor
|
It looks good!
|
Contributor
Author
Sure! That sounds good! |
Contributor
Author
|
Close this PR, pivot for #400 that is created in the main repo to run the tests. |
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first step to enable the keyword arguments of liger functional #368.
torch.autograd.Function) with an extra layer that can take key word arguments.test_{operator_name}.py::test_correctness_functionalto reflect that keyword args can be accepted.transformers/monkey_patch.pyTesting Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence