Skip to content

{python3_17} Python3: fix unicode in url.py#227

Merged
anarcat merged 1 commit intolinkchecker:masterfrom
cjmayo:python3_17
Apr 24, 2019
Merged

{python3_17} Python3: fix unicode in url.py#227
anarcat merged 1 commit intolinkchecker:masterfrom
cjmayo:python3_17

Conversation

@cjmayo
Copy link
Copy Markdown
Contributor

@cjmayo cjmayo commented Apr 10, 2019

No description provided.

Copy link
Copy Markdown
Contributor

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, provided that we merge #214 first.

linkcheck/url.py Outdated
import urlparse

import requests
from builtins import str as text
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would even suggest text_type, but that might be just that I'm so used to six)

@cjmayo
Copy link
Copy Markdown
Contributor Author

cjmayo commented Apr 11, 2019

Rebased on master for build checks.

@cjmayo
Copy link
Copy Markdown
Contributor Author

cjmayo commented Apr 19, 2019

Updated for str_text and rebased.

Copy link
Copy Markdown
Contributor

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anarcat anarcat merged commit 492da5a into linkchecker:master Apr 24, 2019
@cjmayo cjmayo deleted the python3_17 branch November 21, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants