{python3_04} Python3: add future to requirements#214
Merged
anarcat merged 1 commit intolinkchecker:masterfrom Apr 11, 2019
Merged
{python3_04} Python3: add future to requirements#214anarcat merged 1 commit intolinkchecker:masterfrom
anarcat merged 1 commit intolinkchecker:masterfrom
Conversation
mgedmin
approved these changes
Apr 11, 2019
Contributor
mgedmin
left a comment
There was a problem hiding this comment.
Personally I'm not familiar with future and would be much happier if the Python 2-and-3 cross compatibility were handled using six, but hey, why not? Especially since the work's already been done using future and it would be extremely churlish of me to ask to re-do it differently.
Merging this would make a lot of the other Python 3 compatibility PRs happier, so I suggest we do it.
(We can always change our minds later and replace future with six or whatever.)
Contributor
|
here we go then, let's do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.