fix: really keep catalog extra from previous catalog#2479
Merged
andrii-bodnar merged 1 commit intolingui:mainfrom Mar 18, 2026
Merged
fix: really keep catalog extra from previous catalog#2479andrii-bodnar merged 1 commit intolingui:mainfrom
andrii-bodnar merged 1 commit intolingui:mainfrom
Conversation
25cfdde tries to keep flags, but it is incorrectly spreading extra, when it should not causing flags to be lost. Additionally, move extra after rest to ensure it is not overwritten. Fixes lingui#2398.
|
@ljani is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
timofei-iatsenko
approved these changes
Mar 18, 2026
Collaborator
|
😳 omg, may bad. Thanks for the fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
==========================================
+ Coverage 77.05% 81.21% +4.16%
==========================================
Files 84 104 +20
Lines 2157 2720 +563
Branches 555 725 +170
==========================================
+ Hits 1662 2209 +547
+ Misses 382 364 -18
- Partials 113 147 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
pushed a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
25cfdde tries to keep
flags, but it is incorrectly spreadingextra, when it should not, causingflagsto be lost.Additionally, move
extraafterrestto ensure it is not overwritten. Not sure if this is needed, but the original commit hints it should be always preferred.See also #2399.
Running the full test suite seems to fail on my machine, but the relevant tests pass.
Description
Types of changes
Fixes #2398.
Checklist