Remove render_to_surface
#803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jaredoconnell
left a comment
There was a problem hiding this comment.
I am not familiar enough with how all of this works to give an approval, but I didn't see any red flags, and it looks well documented.
bc06a68 to
2723a6a
Compare
2723a6a to
32bcd15
Compare
render_to_surface and the async pipelinerender_to_surface
waywardmonkeys
approved these changes
Feb 11, 2025
Collaborator
waywardmonkeys
left a comment
There was a problem hiding this comment.
I think I'm good with this once the clippy and doc stuff is fixed.
This is a step forward and we'll want to iterate more before the next release!
Thanks for pulling out the async changes as that made this easier to understand.
vello/src/lib.rs
Outdated
| /// This pattern is supported by the [`util`] module. | ||
| /// 2) Call `render_to_texture` directly on the [`SurfaceTexture`][wgpu::SurfaceTexture]'s texture, if | ||
| /// it has the right usages. This should generally be avoided, as it's a potential performance pitfall | ||
| /// on GPUs where the render pipeline method of writing to surfaces is assumed and optimised for. |
Collaborator
There was a problem hiding this comment.
Something about this phrasing is confusing to me.
Member
Author
There was a problem hiding this comment.
I've tried to rephrase this.
Member
Author
|
The async pipeline with |
waywardmonkeys
approved these changes
Feb 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2025
This accidentally bitrotted when we implemented #803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with blitting/texture utilities in the
utilsmodule.Fixes #549
Incompatible with #801. I have a follow-up which shows you would do transparency, but my current thinking is that you should drop off the "utils" happy path if you need that. I could be convinced otherwise.