Skip to content

fix(vscode,lsp): programmatic config stopped working#2896

Merged
davydkov merged 1 commit into
mainfrom
fix/vscode-lsp-programmatic-config
Apr 15, 2026
Merged

fix(vscode,lsp): programmatic config stopped working#2896
davydkov merged 1 commit into
mainfrom
fix/vscode-lsp-programmatic-config

Conversation

@davydkov

@davydkov davydkov commented Apr 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace esbuild-wasm alias with real esbuild and bundle-require as runtime dependencies in both likec4-vscode and @likec4/lsp packages
  • The esbuild-wasm alias prevented bundle-require from loading programmatic config files (likec4.config.ts)

Test plan

  • Verify VSCode extension loads likec4.config.ts programmatic config
  • Verify standalone LSP loads likec4.config.ts programmatic config
  • Verify extension builds successfully

🤖 Generated with Claude Code

@davydkov @claude
fix(vscode,lsp): replace esbuild-wasm with esbuild for programmatic c…
add8be6 
…onfig support

esbuild-wasm alias prevented bundle-require from loading programmatic
config files (likec4.config.ts). Use real esbuild and bundle-require
as runtime dependencies instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c997c95b-486c-4f18-b938-c008bf3571de

📥 Commits

Reviewing files that changed from the base of the PR and between eb57e11 and add8be6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • .changeset/fix-vscode-programmatic-config.md
  • packages/lsp/package.json
  • packages/lsp/tsdown.config.mts
  • packages/vscode/package.json
  • packages/vscode/tsdown.config.ts
💤 Files with no reviewable changes (2)
  • packages/lsp/tsdown.config.mts
  • packages/vscode/tsdown.config.ts
📝 Walkthrough

Walkthrough

This changeset fixes programmatic configuration loading in the VSCode extension and standalone LSP by transitioning from esbuild-wasm to native esbuild. Dependencies are added to both packages, esbuild-wasm is removed, and corresponding build aliases are eliminated.

Changes

Cohort / File(s) Summary
Dependency & Configuration Metadata
.changeset/fix-vscode-programmatic-config.md		 New changelog entry documenting the fix for programmatic configuration not being loaded in VSCode extension and standalone LSP.
LSP & VSCode Package Dependencies
packages/lsp/package.json, packages/vscode/package.json		 Added bundle-require and esbuild as runtime dependencies; removed esbuild-wasm from devDependencies in both packages to use native esbuild instead of wasm variant.
LSP & VSCode Build Configuration
packages/lsp/tsdown.config.mts, packages/vscode/tsdown.config.ts		 Removed esbuild module alias mappings that previously resolved to esbuild-wasm, allowing esbuild resolution to use default behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes a clear summary of changes and test plan, but the checklist items are not filled out, leaving the PR verification status unclear. Complete the PR checklist to confirm that contribution guidelines were followed, tests were added, and documentation was updated if necessary.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(vscode,lsp): programmatic config stopped working' clearly and concisely summarizes the main issue being addressed: fixing programmatic config loading in the VSCode extension and LSP packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vscode-lsp-programmatic-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davydkov davydkov merged commit d628461 into main Apr 15, 2026
17 checks passed
@davydkov davydkov deleted the fix/vscode-lsp-programmatic-config branch April 15, 2026 13:33
@likec4-ci likec4-ci Bot mentioned this pull request Apr 15, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 16, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davydkov