.changeset/add-standalone-lsp-package.md (1)

1-9: Consider using minor for the new package.

The changeset correctly follows the required format and references the fixed issue. However, since @likec4/lsp is a new package introducing new functionality (not just a patch fix), consider whether minor would be more semantically appropriate than patch for @likec4/lsp.

That said, if this is a v0.x package or the team prefers patch for new packages, the current version is fine.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.changeset/add-standalone-lsp-package.md around lines 1 - 9, Update the
changeset so the new package '@likec4/lsp' is released as a minor instead of a
patch: change the line listing '@likec4/lsp': patch to '@likec4/lsp': minor in
the changeset content (keeping '@likec4/language-server' as patch if intended);
ensure the changeset still references the issue and message unchanged.

apps/docs/src/content/docs/tooling/editors.mdx (1)

92-100: Consider adding an lsp-mode example for Emacs users.

The section mentions both lsp-mode and eglot but only provides an eglot configuration example. Many Emacs users prefer lsp-mode.

📝 Optional: Add lsp-mode configuration

 Use `@likec4/lsp` with [lsp-mode](https://emacs-lsp.github.io/lsp-mode/) or [eglot](https://github.com/joaotavora/eglot):
 
 ```elisp
 ;; eglot
 (add-to-list 'eglot-server-programs
              '((likec4-mode) . ("likec4-lsp" "--stdio")))
+
+;; lsp-mode
+(lsp-register-client
+ (make-lsp-client :new-connection (lsp-stdio-connection '("likec4-lsp" "--stdio"))
+                  :major-modes '(likec4-mode)
+                  :server-id 'likec4-lsp))
 ```

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/docs/src/content/docs/tooling/editors.mdx` around lines 92 - 100, Add an
lsp-mode example alongside the existing eglot snippet: register a client for
likec4-mode by calling lsp-register-client with make-lsp-client using
lsp-stdio-connection configured to run "likec4-lsp --stdio", set :major-modes to
'(likec4-mode) and :server-id to a unique symbol like 'likec4-lsp so Emacs
lsp-mode users have a ready configuration.

packages/lsp/package.json (1)

22-27: The **/package.json glob in files array may include unintended files.

This pattern could match node_modules/**/package.json or other nested package.json files during local development if not properly filtered. Consider being more specific with "package.json" only.

📝 Proposed fix

   "files": [
     "bin",
     "dist",
-    "**/package.json",
+    "package.json",
     "!**/*.map"
   ],

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/package.json` around lines 22 - 27, The "files" array currently
includes the glob "**/package.json" which can inadvertently include nested
package.json files (e.g., node_modules/**/package.json); update the "files"
array entry in package.json to a more specific pattern such as "package.json"
(or add an explicit exclusion like "!node_modules/**/package.json") so only the
root package.json is published; edit the "files" array entry that currently
contains "**/package.json" to the chosen safer pattern.

packages/lsp/README.md (1)

83-83: Consider hyphenating "open-source" when used as an adjective.

"Open-source" should be hyphenated when used as a compound adjective modifying "project."

📝 Proposed fix

-LikeC4 is a MIT-licensed open source project with its ongoing development made possible entirely by your support.\
+LikeC4 is a MIT-licensed open-source project with its ongoing development made possible entirely by your support.\

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/README.md` at line 83, Change the phrase "open source" to the
hyphenated adjective form "open-source" in the README sentence that currently
reads "LikeC4 is a MIT-licensed open source project..." so it becomes "LikeC4 is
a MIT-licensed open-source project..." to correctly hyphenate the compound
adjective.

packages/lsp/src/standalone.ts (1)

22-47: Clean implementation with proper error handling and logger configuration.

The function correctly:

• Sets up error handlers to log uncaught exceptions/rejections
• Creates an LSP connection with auto-detected transport
• Configures stderr for logging (preserving stdout for LSP protocol)
• Allows user override of logger options via spread operator

One minor suggestion: consider adding an explicit return type annotation for better API documentation.

📝 Optional: Add explicit return type

-export function startStandaloneLsp(options?: StandaloneLspOptions) {
+export function startStandaloneLsp(options?: StandaloneLspOptions): ReturnType<typeof startLanguageServer> {

Or define a named type if startLanguageServer returns a specific interface.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/src/standalone.ts` around lines 22 - 47, Add an explicit return
type to startStandaloneLsp to improve API docs and type safety: update the
signature of startStandaloneLsp (which currently accepts StandaloneLspOptions)
to declare the exact return type produced by startLanguageServer (either the
concrete interface it returns or use TypeScript's ReturnType<typeof
startLanguageServer>) so the function signature clearly communicates its return
contract; locate startStandaloneLsp in this file and change its declaration
accordingly.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/lsp/src/standalone.ts (3)

69-74: Register process-level error handlers only once.

Lines 69-74 add global listeners on each call; repeated startStandaloneLsp() calls can accumulate handlers and duplicate error logging.

Suggested patch

+let processHandlersRegistered = false
+
 export function startStandaloneLsp(options?: StandaloneLspOptions): void {
@@
-  process.on('uncaughtException', (err) => {
-    logger.error('uncaughtException', { err })
-  })
-  process.on('unhandledRejection', (err) => {
-    logger.error('unhandledRejection', { err })
-  })
+  if (!processHandlersRegistered) {
+    process.on('uncaughtException', (err) => {
+      logger.error('uncaughtException', { err })
+    })
+    process.on('unhandledRejection', (err) => {
+      logger.error('unhandledRejection', { err })
+    })
+    processHandlersRegistered = true
+  }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/src/standalone.ts` around lines 69 - 74, The process-level error
handlers in startStandaloneLsp() are being added on every invocation causing
duplicate logs; modify startStandaloneLsp() so it registers the handlers only
once by using a module-scoped guard (e.g., a boolean like handlersRegistered) or
by checking process.listenerCount for 'uncaughtException'/'unhandledRejection'
before adding; refactor the anonymous callbacks into named functions (e.g.,
onUncaughtException, onUnhandledRejection) and only call process.on(...) when
the guard indicates handlers are not yet registered, then set the guard to true.

---

58-58: Add an explicit return type to the exported API.

Line 58 currently relies on inference; please declare : void explicitly for startStandaloneLsp.

Suggested patch

-export function startStandaloneLsp(options?: StandaloneLspOptions) {
+export function startStandaloneLsp(options?: StandaloneLspOptions): void {

As per coding guidelines, `**/*.{ts,tsx}`: TypeScript-first repo; use explicit types.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/src/standalone.ts` at line 58, The exported function
startStandaloneLsp currently relies on type inference for its return type;
change its signature to declare an explicit return type of void by updating the
function declaration (startStandaloneLsp) to include ": void" after the
parameter list so the exported API is explicitly typed; ensure the
implementation still returns nothing (or use an explicit return; statement) so
the declared void type is accurate.

---

8-8: Rename startLanguim alias to fix typo and improve readability.

Small naming typo (startLanguim) can be cleaned up to avoid propagation in future edits.

Also applies to: 85-85

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/src/standalone.ts` at line 8, The import alias startLanguim has
a typo; change the import to use a correct, readable name (e.g., import {
startLanguageServer as startLanguageServer } or simply import {
startLanguageServer } from 'langium/lsp') and update all references to
startLanguim (such as the call at the usage around the reference on line ~85) to
the new identifier (startLanguageServer) so the import and its usages match.

packages/lsp/src/standalone.ts (1)

1-9: Typo in import alias: startLanguim → startLangium.

Minor typo in the alias name that could cause confusion when reading the code.

📝 Proposed fix

-import { startLanguageServer as startLanguim } from 'langium/lsp'
+import { startLanguageServer as startLangium } from 'langium/lsp'

And on line 85:

-  startLanguim(services.shared)
+  startLangium(services.shared)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/src/standalone.ts` around lines 1 - 9, Rename the mis-typed
import alias startLanguim to startLangium in the imports so the langium export
is correctly named; update every usage of startLanguim to startLangium (e.g.,
where startLanguageServer is re-exported or invoked) to keep identifiers
consistent with the langium package and avoid confusion.

packages/lsp/README.md (1)

83-83: Consider hyphenating "open-source" as compound adjective.

When used as a compound adjective before a noun ("open-source project"), the hyphenated form is grammatically preferred.

📝 Proposed fix

-LikeC4 is a MIT-licensed open source project with its ongoing development made possible entirely by your support.\
+LikeC4 is a MIT-licensed open-source project with its ongoing development made possible entirely by your support.\

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/lsp/README.md` at line 83, Replace the phrase "LikeC4 is a
MIT-licensed open source project" so that "open-source" is hyphenated when used
as a compound adjective—update the text to "LikeC4 is a MIT-licensed open-source
project" (locate the exact sentence containing "LikeC4 is a MIT-licensed open
source project" to apply the change).