rpc: expose invoice features in decodepayreq#3802
Merged
Roasbeef merged 5 commits intolightningnetwork:masterfrom Dec 10, 2019
Merged
rpc: expose invoice features in decodepayreq#3802Roasbeef merged 5 commits intolightningnetwork:masterfrom
Roasbeef merged 5 commits intolightningnetwork:masterfrom
Conversation
7ffcf3f to
565c01f
Compare
Roasbeef
requested changes
Dec 7, 2019
Member
Roasbeef
left a comment
There was a problem hiding this comment.
Straightforward preparatory PR, only a few minor comments.
lnwire/features.go
Outdated
Member
There was a problem hiding this comment.
In the commit message: featire -> feature.
Perhaps we should leave displaying the bit for unknown features?
Contributor
Author
There was a problem hiding this comment.
the bit is exposed separately in the rpc, wouldn't it be redundant?
565c01f to
ac28846
Compare
halseth
reviewed
Dec 9, 2019
ac28846 to
b11449e
Compare
Member
|
Needs rebase (just protos). |
b11449e to
abc5a2e
Compare
Contributor
Author
|
@Roasbeef rebased |
abc5a2e to
a118e14
Compare
Originally the feature namespaces were destined to be split, but this has changed with the introduction of flat features.
The number and the name will be separate on the rpc level, so we remove the feature bit from the string. Currently this method is unused apart from maybe in some rare logging instances.
a118e14 to
1367187
Compare
This was referenced Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #3679
Now that all invoices have been migrated to have features vectors (#3693),
we can expose this info via the rpc interface. Invoices generated prior to
this commit will show an empty list, but new invoices will set
lnwire.TLVOnionPayloadOptionalas configured in the defaultfeature.Manager.Note that for now this feature bit will be ignored by the router, but this will
change once #3679 is finalized.