migrate to tlv for invoice body#3693
Merged
Roasbeef merged 8 commits intolightningnetwork:masterfrom Nov 26, 2019
Merged
Conversation
08affcc to
e910d5b
Compare
e910d5b to
cce84bf
Compare
halseth
suggested changes
Nov 11, 2019
cce84bf to
1e85e61
Compare
joostjager
reviewed
Nov 12, 2019
59bec21 to
c685d51
Compare
joostjager
approved these changes
Nov 13, 2019
Contributor
|
Build generates a diff in |
joostjager
suggested changes
Nov 13, 2019
Contributor
joostjager
left a comment
There was a problem hiding this comment.
Tested upgrading from 0.8.0-beta to this branch. This is the ListInvoices diff. Seems not ok
c685d51 to
102b243
Compare
Contributor
Author
Looked into this, the
also fixed, a |
102b243 to
1ee9e2c
Compare
0ebc88e to
2ba8cc3
Compare
Contributor
Author
|
@joostjager @Roasbeef @halseth reverted to prior pr and touched up for another review. ended up using joost's suggestion of passing through the htlc bytes directly, which shaved 200+ lines off the diff |
2ba8cc3 to
7cc3281
Compare
joostjager
reviewed
Nov 20, 2019
Contributor
joostjager
left a comment
There was a problem hiding this comment.
Looking better with htlc pass through.
ecdf974 to
1cd1a93
Compare
These will allow us to serialize invoice features bits without double encoding the length.
Instead of allocating a byte slice to read in each htlc's raw TLV stream, use a LimitReader to truncate the stream to the proper length.
This commit restructures an invoice's ContractTerms to better encompass the restrictions placed on settling. For instance, the final ctlv delta and invoice expiry are moved from the main invoice body (where additional metadata is stored). Additionally, it moves the State field outside of the terms since it is rather metadata about the invoice instead of any terms offered to the sender in the payment request.
1cd1a93 to
3b253e0
Compare
Roasbeef
approved these changes
Nov 26, 2019
Member
Roasbeef
left a comment
There was a problem hiding this comment.
LGTM 📯
Latest diff on my node just shows the reciept field being removed between versions (diff'ing calls to ListInvoices) 👍
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #3685
This PR migrates our invoices to use TLV for their bodies. In the process we add feature vectors and payment addrs to make way for our mpp series. The unused receipt field is ultimately dropped from the db and the rpc calls. Finally, invoices are now populated with an empty set of features, which will not appear on payment requests until a non-zero number of bits are initially set.