Concretize Output Ordering to be less confusing#876
Merged
t-bast merged 2 commits intolightning:masterfrom Jun 21, 2021
Merged
Conversation
c369440 to
e39fcbd
Compare
t-bast
reviewed
May 25, 2021
Collaborator
t-bast
left a comment
There was a problem hiding this comment.
Needs rebase, otherwise LGTM 👍
e39fcbd to
b68bf7c
Compare
Collaborator
Author
|
Rebased. |
t-bast
approved these changes
May 25, 2021
Collaborator
|
Ack b68bf7c |
12 tasks
This comment was marked as abuse.
This comment was marked as abuse.
3132566 to
22d7494
Compare
t-bast
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #872 and takes rusty's suggestion of just using a list. I've found linking to BIP 69 (which is itself underspecified) confusing from the first time I read this.
Fixes #456.