Merged
Conversation
Roasbeef
approved these changes
Dec 6, 2021
Contributor
Roasbeef
left a comment
There was a problem hiding this comment.
Carrying over my approval here from the other repo
LGTM ☄️
TheBlueMatt
approved these changes
Dec 6, 2021
t-bast
approved these changes
Dec 7, 2021
|
Hi, I know I don't comment here much (I observe though) I am curious as to why is the |
Contributor
|
Agreed, I find bLIP kinda weird, not sure why it uses this casing. |
ffranr
pushed a commit
to ffranr/blips
that referenced
this pull request
Apr 4, 2024
blip-29: use Unix timestamp for RFQ accepted quote expiry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR initializes the new bLIPs repo with a README modeled after the BIPs README, and adds bLIP-0001, which was previously being discussed in PR #884 in the lightning-rfc repo.
Only a few adjustments have been made to bLIP-0001 while transferring from the previous repo:
Universalitysection requesting proposals "discuss why the given feature is not intended to beuniversal and why it's still a good idea as a non-universal protocol" per @TheBlueMatt's feedback.
Once these two docs are merged, the next step IMO will be to close the old PR and open a new one for a BOLT #13 (?) that acts as a central registry for bLIP'd Feature Bits, Message Types, and TLVs (and maybe more down the road...) per @t-bast's feedback (replacing PRs #605 and #716 from lightning-rfc). Maybe specifying the process of approving a bLIP using one of these resources, and then adding the resource assignment to the new BOLT, could be a good bLIP-0002?