Skip to content

Support pnpm v9#803

Merged
MikeMcQuaid merged 1 commit into
licensee:mainfrom
nozaq:pnpm9
Feb 17, 2025
Merged

Support pnpm v9#803
MikeMcQuaid merged 1 commit into
licensee:mainfrom
nozaq:pnpm9

Conversation

@nozaq

@nozaq nozaq commented Feb 15, 2025

Copy link
Copy Markdown
Collaborator

pnpm v9 has changed its license output format. The version and path keys have been replaced with versions and paths, respectively, which now store arrays.

This PR includes the following changes:

  • Adds pnpm v9 to the test matrix.
  • Supports the pnpm v9 format while remaining compatible with the previous format.

fixes #783

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nozaq, you rock!

@MikeMcQuaid MikeMcQuaid merged commit 4387e49 into licensee:main Feb 17, 2025
@nozaq

nozaq commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator Author

@MikeMcQuaid
Thank you for reviewing the patch! Do you have any plans to make a new release so that people can use it via setup-licensed?

@MikeMcQuaid

MikeMcQuaid commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

@nozaq Done, thanks for nudge: https://github.com/licensee/licensed/releases/tag/v5.0.3

GitHub
What's Changed

Support pnpm v9 by @nozaq in #803

New Contributors

@nozaq made their first contribution in #803

Full Changelog: v5.0.2...v5.0.3

@nozaq

nozaq commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator Author

@MikeMcQuaid Great! Thank you for keep maintaining licensed by the way, it helps us a lot 🚀

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

@nozaq You're welcome! Same here, that's why I offered to help maintain it 😁. If you're ever interested in helping out with maintaining it and e.g. reviewing my PRs: shout!

@nozaq

nozaq commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator Author

@MikeMcQuaid I'd be happy to help out 👍🏼 It seems there are quite a few obvious tasks, such as reviewing old issues and fixing recently suspended or failing CI tests 😉

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

@nozaq Great, thanks! Would you like me to make a list of some suggested tasks somewhere or are you happy to just get started? Could grant you maintainer access after 0-2 more PRs? Let me know what you think!

@nozaq

nozaq commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator Author

@MikeMcQuaid It would be great if you could suggest some tasks, as I don’t have enough context about what’s been going on in this repository. Just in case they’re needed, here are some tasks I would propose:

  • Fix the test cases that were recently disabled (such as NuGet and pipenv 3.x).
  • Add tests to the CI test matrix to detect failures with newer package manager versions.

Regarding maintainer access, I completely understand and agree that ensuring security is paramount. If and when you decide it’s the right time to grant access, I’ll be ready, but I’m not in any hurry. Until then, I’m happy to continue submitting PRs or adding review comments as needed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Unable to read when using pnpm v9

2 participants