Revert "linux: eliminate a read on eventfd per wakeup (#4400)"#4585
Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom Oct 17, 2024
Merged
Revert "linux: eliminate a read on eventfd per wakeup (#4400)"#4585bnoordhuis merged 1 commit intolibuv:v1.xfrom
bnoordhuis merged 1 commit intolibuv:v1.xfrom
Conversation
This reverts commit e5cb1d3. Reason: bisecting says it breaks dnstap. Also revert commit 2713454 ("kqueue: use EVFILT_USER for async if available") because otherwise the first commit doesn't revert cleanly, with enough conflicts in src/unix/async.c that I'm not comfortable fixing those up manually. Fixes: libuv#4584
cjihrig
approved these changes
Oct 17, 2024
santigimeno
approved these changes
Oct 17, 2024
Member
|
Belated 👍, thanks Ben! |
vtjnash
added a commit
that referenced
this pull request
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e5cb1d3.
Reason: bisecting says it breaks dnstap.
Also revert commit 2713454 ("kqueue: use EVFILT_USER for async if available") because otherwise the first commit doesn't revert cleanly, with enough conflicts in src/unix/async.c that I'm not comfortable fixing those up manually.
Fixes: #4584
cc @panjf2000