win: fix uv_available_parallelism on win32#4525
Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom Sep 2, 2024
Merged
Conversation
Fixes commit 58dfb6c from a few days ago. DWORD_PTR is 32 bits on x86 Windows. Use the right bit count when checking the population count. Interestingly enough, it manifested itself as double counting available processors, presumably because the compiler emits a ROR instead of SHR. Fixes: libuv#4524
cjihrig
approved these changes
Sep 1, 2024
saghul
approved these changes
Sep 2, 2024
giordano
pushed a commit
to JuliaLang/libuv
that referenced
this pull request
Sep 2, 2024
Fixes commit 58dfb6c from a few days ago. DWORD_PTR is 32 bits on x86 Windows. Use the right bit count when checking the population count. Interestingly enough, it manifested itself as double counting online processors, presumably because the compiler emits a ROR instead of SHR. Fixes: libuv#4524 (cherry picked from commit 5ff1fc7)
giordano
pushed a commit
to JuliaLang/libuv
that referenced
this pull request
Sep 2, 2024
Fixes commit 58dfb6c from a few days ago. DWORD_PTR is 32 bits on x86 Windows. Use the right bit count when checking the population count. Interestingly enough, it manifested itself as double counting online processors, presumably because the compiler emits a ROR instead of SHR. Fixes: libuv#4524 (cherry picked from commit 5ff1fc7)
giordano
added a commit
to giordano/Yggdrasil
that referenced
this pull request
Sep 2, 2024
giordano
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes commit 58dfb6c from a few days ago. DWORD_PTR is 32 bits on x86 Windows. Use the right bit count when checking the population count.
Interestingly enough, it manifested itself as double counting available processors, presumably because the compiler emits a ROR instead of SHR.
Fixes: #4524