Skip to content

win/spawn: optionally run executable paths with no file extension#4292

Merged
vtjnash merged 3 commits intolibuv:v1.xfrom
bradking:win-spawn-no-file-extension
Feb 5, 2024
Merged

win/spawn: optionally run executable paths with no file extension#4292
vtjnash merged 3 commits intolibuv:v1.xfrom
bradking:win-spawn-no-file-extension

Conversation

@bradking
Copy link
Copy Markdown
Contributor

@bradking bradking commented Jan 23, 2024

Add a UV_PROCESS_WINDOWS_FILE_PATH_EXACT_NAME flag to enable the optional behavior.

Prompted by https://gitlab.kitware.com/cmake/cmake/-/issues/25450#note_1451473. Continuing from #4241.

@bradking bradking changed the title win/spawn: run executables with no file extension win/spawn: optionally run executable paths with no file extension Jan 24, 2024
bradking added a commit to bradking/libuv that referenced this pull request Jan 24, 2024
…buv#4292)

Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
@bradking bradking force-pushed the win-spawn-no-file-extension branch from f997efe to 48dc6f6 Compare January 24, 2024 19:07
bradking added a commit to bradking/libuv that referenced this pull request Jan 24, 2024
…buv#4292)

Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
@bradking bradking force-pushed the win-spawn-no-file-extension branch from 48dc6f6 to a6d0883 Compare January 24, 2024 19:32
…buv#4292)

Add a process options flag to enable the optional behavior.

Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
@bradking bradking force-pushed the win-spawn-no-file-extension branch from a6d0883 to 66e6a6a Compare January 24, 2024 19:52
@bradking
Copy link
Copy Markdown
Contributor Author

@vtjnash @bnoordhuis this supersedes #4241 and preserves backward compatibility by making the behavior opt-in with a flag.

@bradking bradking mentioned this pull request Feb 2, 2024
@vtjnash vtjnash merged commit 3f7191e into libuv:v1.x Feb 5, 2024
@bradking bradking deleted the win-spawn-no-file-extension branch February 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants