fix oopsie from #3466#3475
Merged
Merged
Conversation
I created `uv__backend_timeout` to be used internally for this reason, then forgot to use it, resulting in flaky tests and excessive trips around the uv_run loop. Fix libuv#3472
cjihrig
approved these changes
Feb 14, 2022
richardlau
approved these changes
Feb 14, 2022
bnoordhuis
added a commit
to bnoordhuis/libuv
that referenced
this pull request
Apr 2, 2022
This reverts commit 939a056. This reverts commit cc7dbaa. Reverted for causing a regression in the Node.js test suite. Also revert "fix oopsie from libuv#3466 (libuv#3475)". Refs: nodejs/node#42340
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
I created `uv__backend_timeout` to be used internally for this reason, then forgot to use it, resulting in flaky tests and excessive trips around the uv_run loop. Fix libuv#3472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created
uv__backend_timeoutto be used internally for this reason,then forgot to use it, resulting in flaky tests and excessive trips
around the uv_run loop.
Fix #3472