Avoid C4319 warnings from UNW_ALIGN#931
Merged
bregma merged 1 commit intolibunwind:masterfrom Jan 8, 2026
Merged
Conversation
Contributor
|
Thanks, LGTM! cc @bregma |
2 tasks
steveisok
pushed a commit
to dotnet/runtime
that referenced
this pull request
Dec 9, 2025
Include libunwind/libunwind#931 in the build of the libunwind dependency. Fixes runtime build errors on `1es-windows-2022-open` that are blocking HTTP & SSL stress runs. ## Customer Impact - [x] Found internally Our internal HTTP and SSL stress tests are failing to build on the 8.0 branch. An update of MSVC in the `1es-windows-2022-open` image brought updated analyzer rules that now fail the build of dotnet/runtime on Windows. ``` mempool.c(96): warning C4319: '~': zero extending 'unsigned long' to 'size_t' of greater size ``` This change adds `(size_t)` casts in the libunwind dependency, which resolves the new errors. ## Regression - [X] Yes Infra update. ## Testing Regular CI is still passing + CI stress runs for HTTP and SSL now build and work again. ## Risk Low. This is a one-line targeted fix that only adds casts.
Member
|
Looking at places where this macro is used with types other than |
ViktorHofer
pushed a commit
to dotnet/runtime
that referenced
this pull request
Jan 23, 2026
Include libunwind/libunwind#931 in the build of the libunwind dependency. Fixes runtime build errors on `1es-windows-2022-open` that are blocking HTTP & SSL stress runs. - [x] Found internally Our internal HTTP and SSL stress tests are failing to build on the 8.0 branch. An update of MSVC in the `1es-windows-2022-open` image brought updated analyzer rules that now fail the build of dotnet/runtime on Windows. ``` mempool.c(96): warning C4319: '~': zero extending 'unsigned long' to 'size_t' of greater size ``` This change adds `(size_t)` casts in the libunwind dependency, which resolves the new errors. - [X] Yes Infra update. Regular CI is still passing + CI stress runs for HTTP and SSL now build and work again. Low. This is a one-line targeted fix that only adds casts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC 19.44.35221.0 now warns on some uses, the added casts avoid it.
cc: @am11