You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Older kernels still in wide use (e.g. Enterprise Linux 8) do not have NT_ARM_PAC_MASK support or the associated structs. Compilation fails:
ptrace/_UPT_ptrauth_insn_mask.c: In function ‘_UPT_ptrauth_insn_mask’:
ptrace/_UPT_ptrauth_insn_mask.c:38:40: error: ‘NT_ARM_PAC_MASK’ undeclared (first use in this function); did you mean ‘EF_ARM_EABIMASK’?
ret = ptrace (PTRACE_GETREGSET, pid, NT_ARM_PAC_MASK, &iovec);
^~~~~~~~~~~~~~~
EF_ARM_EABIMASK
ptrace/_UPT_ptrauth_insn_mask.c:38:40: note: each undeclared identifier is reported only once for each function it appears in
This patch disables this codepath unless this is a Linux host and NT_ARM_PAC_MASK is defined in elf.h.
See also #873 which proposes a fix for FreeBSD platforms. This patch is a superset of #870.
After some investigation I believe it should be #if defined(UNW_TARGET_AARCH64) && defined(NT_ARM_PAC_MASK). Compilation support for that macro is independent of the target operating system.
Please make that change and I would be happy to commit.
After some investigation I believe it should be #if defined(UNW_TARGET_AARCH64) && defined(NT_ARM_PAC_MASK). Compilation support for that macro is independent of the target operating system.
Please make that change and I would be happy to commit.
Requested changed committed. Once merged I'd like to issue a PR to backport this change and some of the UNUSED fixes into v1.8-stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older kernels still in wide use (e.g. Enterprise Linux 8) do not have
NT_ARM_PAC_MASKsupport or the associated structs. Compilation fails:This patch disables this codepath unless this is a Linux host and
NT_ARM_PAC_MASKis defined inelf.h.See also #873 which proposes a fix for FreeBSD platforms. This patch is a superset of #870.