Fix typo in crypt.c #218
Merged
Fix typo in crypt.c #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willco007
approved these changes
Oct 20, 2017
Member
willco007
left a comment
There was a problem hiding this comment.
Good catch; note this will only fail if you have LIBSSH2_CRYPT_NONE enabled. If I'm not mistaken, if you try and actually use no cipher it will crash when trying to call init/dtor on NULL pointers. I have a fix on my branch for that which I should push.
Contributor
Author
|
That would explain why this was not seen in my autoconf builds then - I had enabled crypt none in cmake only. Thanks for the heads up also 👍 |
kbulgrien
pushed a commit
to kbulgrien/libssh2-1.2.4-sco3.2v5.0.7
that referenced
this pull request
Dec 14, 2018
alex-weaver
pushed a commit
to alex-weaver/libssh2
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master branch cmake compile currently failing with