Make building SDL without X11 or Wayland harder#11310
Merged
madebr merged 1 commit intolibsdl-org:mainfrom Oct 23, 2024
Merged
Conversation
slouken
reviewed
Oct 23, 2024
5b25e35 to
dcab543
Compare
It's still possible to build SDL by configuring with -DSDL_NO_UNIX_DESKTOP_SANITY_CHECK=ON
dcab543 to
ed02977
Compare
slouken
approved these changes
Oct 23, 2024
Collaborator
|
Looks good, thanks! |
Contributor
|
Where does kmsdrm fit into this equation? |
Collaborator
It's one of the use cases where you might define SDL_UNIX_CONSOLE_BUILD. |
Contributor
Author
|
Just confirming the urls at https://github.com/libsdl-org/SDL/actions/runs/11485676931/job/31966322812#step:23:502 work. RTFM :) |
11 tasks
klukaszek
pushed a commit
to klukaszek/SDL
that referenced
this pull request
Nov 17, 2024
…-org#11310) It's still possible to build SDL by configuring with -DSDL_NO_UNIX_DESKTOP_SANITY_CHECK=ON
Contributor
Author
Collaborator
I'm inclined not to change build behavior in SDL2, since people may have automated scripts set up for it at this point. |
Contributor
Author
Aight, I'll revert my patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still possible to build SDL by configuring with
-DSDL_NO_UNIX_DESKTOP_SANITY_CHECK=ONThe error message is:
Error on ci:
https://github.com/madebr/SDL/actions/runs/11485462451/job/31965601937#step:23:533
The reason for this change is that we were receiving lots of support questions about why linux apps were not displaying a window.
I hope breaking the build and providing links to locations where to fix the build is enough.
SDL_NO_UNIX_DESKTOP_SANITY_CHECKis explicitly NOT mentioned in the error message to avoid people blindly copying it.Description
Existing Issue(s)