Update github actions and fix iwyu build target.
#243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old v2 versions of these github actions now produce errors warning you need to update them.
The iwyu package dependencies have been fixed, and this old package doesn't exist any more.
56ca888 to
32826df
Compare
Member
Author
|
Note the lint check is now working correctly, but it's still failing because the iwyu test thinks the includes for fileutil.c and rabinkarp_perf.c are excessive. In the case of fileutil.c, this is a platform-compatibility package that might not need some headers on linux, but might on other platforms. So this is a failure that can/should be ignored. Maybe we should somehow setup the tests to ignore this? For rabinkarp_perf.c it's probably right, and it should be adjusted. |
This format is much more compact and easier to read.
iwyu build target.
Contributor
|
It looks like iwyu is failing in CI (https://github.com/librsync/librsync/actions/runs/14822488789/job/41611359535) in a way that I can not yet reproduce locally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old v2 versions of
checkoutandupload-artifactgithub actions now produce errors warning they must be updated. The new versions are v3.The
iwyupackage has now fixed it's deps and we no longer need to explicitly installlibclang-common-9-devwhich doesn't exist any more.The
iwyubuild target should ignorefileutil.c, and use neater clang output with noisy "note:" output removed.Run
make iwyu-fixto fix includes fortests/rabinkarp_perf.c.