You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review of the spec itself concluded in libp2p/go-libp2p-circuit#1 -- the additional changes in this PR are purely linking it into place.
I chose to categorize the relay primarily as a transport, since that is what it looks like to the layers using it -- you use it by means of /p2p-circuit multiaddrs, just like other transports. The fact that it's also a swarm protocol is an implementation detail from this point of view.
Still a great fan of the dramatization :) I would say that we should take this opportunity to make sure that the protocol strings are very clear and well scoped (e.g relay is a libp2p thing and not an ipfs one)
@lgierth I've updated the links and the multicodec in the multicodecs table. I understand that his spec is still a WIP, but let's make it a WIP with a placeholder in master, so that we have an entry point for it and then update the spec as the implemention develops. (Trying to avoid having 50 spec fragments everywhere)
Yes totally agree that we should merge this. While the spec is WIP and will be for a while longer, it's definitely good enough to be merged as a first draft.
jxs
pushed a commit
to jxs/specs
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of the spec itself concluded in libp2p/go-libp2p-circuit#1 -- the additional changes in this PR are purely linking it into place.
I chose to categorize the relay primarily as a transport, since that is what it looks like to the layers using it -- you use it by means of
/p2p-circuitmultiaddrs, just like other transports. The fact that it's also a swarm protocol is an implementation detail from this point of view.