Make messageIDs bytes instead of strings#285
Merged
vyzo merged 1 commit intolibp2p:masterfrom Jul 25, 2020
Merged
Conversation
Rationale: - go-libp2p currently produces non-utf8 strings - making this bytes allows more flexibility in creating message ids, e.g. - random bytes - hashes
rklaehn
added a commit
to rklaehn/go-libp2p-pubsub
that referenced
this pull request
Jul 24, 2020
This was referenced Jul 24, 2020
daviddias
pushed a commit
to libp2p/go-libp2p-pubsub
that referenced
this pull request
Jul 27, 2020
Nashatyrev
added a commit
to libp2p/jvm-libp2p
that referenced
this pull request
Nov 9, 2020
Nashatyrev
added a commit
to libp2p/jvm-libp2p
that referenced
this pull request
Nov 9, 2020
Nashatyrev
added a commit
to libp2p/jvm-libp2p
that referenced
this pull request
Nov 10, 2020
* Initial refactor: replace Rpc.Message with abstract PubsubMessage which is created by pluggable messageFactory. messageFactory replaces messageIdGenerator because of PubsubMessage.messageId property * Convert messageId from String to byte[] (see spec PR: libp2p/specs#285) * Use WBytes ByteArray wrapper instead of plain ByteArray because of equals/hashCode absence * Replace AbstractRouter.seenMessages with a special SeenCache interface which is capable of handling PubsubMessage.messageId in a lazy fashion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
This issue was discovered in libp2p/rust-libp2p#1671 . There is a coresponding issue in go-ipfs-pubsub, libp2p/go-libp2p-pubsub#361
Changing this should have no negative impact. Implementations that expect valid utf-8 strings are already broken, because go-ipfs emits non utf8 strings. See libp2p/go-libp2p-pubsub#361 (comment)