fix(quic): don't report error for gracefully closed connections#4621
Merged
mergify[bot] merged 5 commits intolibp2p:masterfrom Oct 12, 2023
Merged
fix(quic): don't report error for gracefully closed connections#4621mergify[bot] merged 5 commits intolibp2p:masterfrom
mergify[bot] merged 5 commits intolibp2p:masterfrom
Conversation
instead of Err(Error::EndpointDriverCrashed) when Accept returns None. Addresses libp2p#4588
mxinden
approved these changes
Oct 10, 2023
Member
mxinden
left a comment
There was a problem hiding this comment.
Thank you for following this all the way through. Much appreciated.
Small suggestions for the changelog entry. Otherwise this looks good to me.
Member
Author
|
Btw, |
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Since adding Quic support on #4577, and due to `quinn`s api nature LH now triggers the [`ListenerClosed`](https://docs.rs/libp2p/0.52.3/libp2p/swarm/struct.ListenerClosed.html) event.. @michaelsproul noticed we are logging this event as `crit!` independently of the reason. This PR matches the reason, logging with `debug!` and `error!` (instead of `crit!`) according to its `Result` ## Additional Info LH will still log `crit!` until libp2p/rust-libp2p#4621 has been merged
Gua00va
pushed a commit
to Gua00va/lighthouse
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Since adding Quic support on sigp#4577, and due to `quinn`s api nature LH now triggers the [`ListenerClosed`](https://docs.rs/libp2p/0.52.3/libp2p/swarm/struct.ListenerClosed.html) event.. @michaelsproul noticed we are logging this event as `crit!` independently of the reason. This PR matches the reason, logging with `debug!` and `error!` (instead of `crit!`) according to its `Result` ## Additional Info LH will still log `crit!` until libp2p/rust-libp2p#4621 has been merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes quinn's
EndpointwithOk(())whenAcceptreturnsNone.Resolves: #4588.
Related: quinn-rs/quinn#1676.
Notes & open questions
Change checklist