Merged
Conversation
yusefnapora
reviewed
Apr 22, 2020
aa66573 to
4e47188
Compare
also, TestScoreInvalidMessageDeliveriesDecay
b9451cc to
d917772
Compare
Contributor
|
reading through, I just realized I'm using the |
Collaborator
|
good point. |
Collaborator
|
failure in |
we seem to take longer to collect the score on travis, which causes the score to be outside the expected bounds. hopefully a longer wait time will give us more wiggle room.
vyzo
pushed a commit
that referenced
this pull request
Apr 23, 2020
* test: score time in mesh * add TestScoreFirstMessageDeliveries * rm redundant initialization to zero * add TestScoreFirstMessageDeliveriesCap * add TestScoreFirstMessageDeliveriesDecay * fix comment * add TestScoreMeshMessageDeliveries * comments * add TestScoreMeshFailurePenalty * add TestScoreInvalidMessageDeliveries also, TestScoreInvalidMessageDeliveriesDecay * add TestScoreApplicationScore * add TestScoreIPColocation * add TestScoreMeshMessageDeliveriesDecay * add TestScoreRetention * try longer interval for TimeInMesh test we seem to take longer to collect the score on travis, which causes the score to be outside the expected bounds. hopefully a longer wait time will give us more wiggle room. Co-authored-by: Yusef Napora <yusef@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #287