Revert "Remove loweredDigits6dots from Spanish Character Definitions"#1623
Closed
jmdaweb wants to merge 2 commits into
Closed
Revert "Remove loweredDigits6dots from Spanish Character Definitions"#1623jmdaweb wants to merge 2 commits into
jmdaweb wants to merge 2 commits into
Conversation
Contributor
Author
|
CC: @ivnc |
bertfrees
reviewed
Aug 24, 2024
Contributor
Author
|
Because I just pressed the revert button on #1574. Do you want to keep the test? |
Member
|
Yes. Unless you say it is wrong, or could be improved. |
Member
|
I tried to fix this PR but I do not have permission. First off I made sure the original copyright statement in the YAML test is kept. Secondly I marked the test as @jmdaweb can you give me permission to push to you branch? |
Contributor
Author
|
Of course. Now you should be able to write. |
Member
|
We should merge #1613 first. |
Member
|
Fixed in #1624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1574 because the change causes the number sign being removed from digits on spanish grade 1 table.