Skip to content

Small fixes to Polish G1#1111

Merged
bertfrees merged 5 commits into
liblouis:masterfrom
lukaszgo1:plG1Fixes
Sep 28, 2021
Merged

Small fixes to Polish G1#1111
bertfrees merged 5 commits into
liblouis:masterfrom
lukaszgo1:plG1Fixes

Conversation

@lukaszgo1

@lukaszgo1 lukaszgo1 commented Sep 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request:

  • Uses correct representation of indexes for squared, cubed etc.
  • Used correct representation for fractions (I haven't added any new to the table just made sure that one present are shown according to the specification)
  • Changes symbol used for underscore from dots 46 to 6 (the former has been too similar to capital letter sign confusing users)

While at i I've also updated metadata of the table. The change from "grade 1" to "literary" is necessary since in Poland Grade 1 means the first level of contractions and the current table does not implement any contractions. Also "grade 1" in itself means nothing since there are two standards of contractions in Poland so with the former description it was not clear which one this table implements.

@bertfrees bertfrees added tables Something that needs to be fixed in table files needs news Update to NEWS file needed labels Sep 8, 2021
@bertfrees bertfrees added this to the 3.20 milestone Sep 8, 2021
bertfrees
bertfrees reviewed Sep 8, 2021
View reviewed changes
Comment thread tables/pl.tbl
bertfrees
bertfrees reviewed Sep 8, 2021
View reviewed changes
Comment thread tables/pl.tbl
@lukaszgo1

lukaszgo1 commented Sep 8, 2021

Copy link
Copy Markdown
Contributor Author

It seems the last failure is not caused by this work. The log says:

FAIL: yaml/partialTrans
=======================

wine client error:0: recvmsg: Connection reset by peer
FAIL yaml/partialTrans.yaml (exit status: 1)

@bertfrees

bertfrees commented Sep 8, 2021

Copy link
Copy Markdown
Member

Yeah no idea what that is. I've tried to re-run the checks but same result...

@bertfrees bertfrees removed the needs news Update to NEWS file needed label Sep 28, 2021
@bertfrees bertfrees merged commit 1726582 into liblouis:master Sep 28, 2021
@lukaszgo1 lukaszgo1 deleted the plG1Fixes branch September 28, 2021 09:47
@lukaszgo1 lukaszgo1 mentioned this pull request Dec 7, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertfrees bertfrees bertfrees left review comments

@egli egli egli approved these changes

Assignees

No one assigned

Labels

tables Something that needs to be fixed in table files

Projects

No open projects
Release 3.20
Status: Merged

Milestone

3.20

Development

Successfully merging this pull request may close these issues.

3 participants

@lukaszgo1 @bertfrees @egli