Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

Add dllexports missing from connection_proxy.h functions.#4

Merged
qmfrederik merged 1 commit intolibimobiledevice-win32:msvc/masterfrom
BillyONeal:add_missing_dllexport
Oct 20, 2020
Merged

Add dllexports missing from connection_proxy.h functions.#4
qmfrederik merged 1 commit intolibimobiledevice-win32:msvc/masterfrom
BillyONeal:add_missing_dllexport

Conversation

@BillyONeal
Copy link
Copy Markdown

This resolves build failures such as:

C:\Dev\vcpkg\buildtrees\libimobiledevice\src\c0f4ce8ad8-13084736e2.clean\include\libimobiledevice/companion_proxy.h(68): note: see declaration of 'companion_proxy_client_new'

BillyONeal added a commit to JackBoosY/vcpkg that referenced this pull request Oct 20, 2020
@qmfrederik
Copy link
Copy Markdown

Awesome, thanks! Let's hope upstream will one day merge these changes ;-)

@qmfrederik qmfrederik merged commit 348aec1 into libimobiledevice-win32:msvc/master Oct 20, 2020
@BillyONeal BillyONeal deleted the add_missing_dllexport branch October 20, 2020 20:17
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Oct 20, 2020
Upstream accepted our fix-functions-declaration.patch in libimobiledevice-win32/libimobiledevice#4 , so fetch that commit and avoid the need to patch.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants