delaunay unit tests, expose is_delaunay, templates, PlainObject -> Matrix#956
Merged
alecjacobson merged 7 commits intodevfrom Oct 28, 2018
Merged
delaunay unit tests, expose is_delaunay, templates, PlainObject -> Matrix#956alecjacobson merged 7 commits intodevfrom
alecjacobson merged 7 commits intodevfrom
Conversation
Contributor
Author
|
Trying again (#955 (comment)). I think this worked correctly. |
fix infinite loop
Collaborator
|
Shall we merge #961 before merging any new test-related PR? Just so that have a common framework to work with. |
Collaborator
|
Ah well I guess not then :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests for the Delaunay triangulation function and exposes the
is_delaunayfunction, with an overload that computes "Delaunay-ness" per (half-)edge. Along the way, I fixed some PlainObjectBase to MatrixBase and added necessary templates.Check all that apply (change to
[x])