Skip to content

Order facets around undirected edge unit test fix#944

Merged
alecjacobson merged 1 commit intodevfrom
unit_test_fix
Oct 16, 2018
Merged

Order facets around undirected edge unit test fix#944
alecjacobson merged 1 commit intodevfrom
unit_test_fix

Conversation

@qnzhou
Copy link
Copy Markdown
Collaborator

@qnzhou qnzhou commented Oct 16, 2018

[Describe your changes and what you've already done to test it.]

In igl::copyleft::cgal::order_facets_around_edges, we need to determine the direction of each undirected edge in order to sort the adjacent facets. This direction is determined by the first directed edge in uE2E[i] list (as shown in this line). However, in the unit test, we are using the direction of uE[i] as the reference direction. This inconsistency causes the unit test in MultipleDuplicatedFaces test case to fail on linux (uE[i] could different on linux and mac, but both are valid since they represent unsigned edge).

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@qnzhou qnzhou changed the base branch from master to dev October 16, 2018 02:10
@alecjacobson alecjacobson merged commit e6116bf into dev Oct 16, 2018
@jdumas jdumas deleted the unit_test_fix branch October 16, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants