Order facets around undirected edge unit test fix#944
Merged
alecjacobson merged 1 commit intodevfrom Oct 16, 2018
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Describe your changes and what you've already done to test it.]
In
igl::copyleft::cgal::order_facets_around_edges, we need to determine the direction of each undirected edge in order to sort the adjacent facets. This direction is determined by the first directed edge inuE2E[i]list (as shown in this line). However, in the unit test, we are using the direction ofuE[i]as the reference direction. This inconsistency causes the unit test inMultipleDuplicatedFacestest case to fail on linux (uE[i]could different on linux and mac, but both are valid since they represent unsigned edge).Check all that apply (change to
[x])