Blue noise sampling on triangle meshes#1597
Merged
alecjacobson merged 7 commits intomasterfrom Sep 17, 2020
Merged
Conversation
Contributor
Author
|
|
jdumas
requested changes
Aug 23, 2020
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Looks good, thanks! My only concerns are about reproducibility, due to the reliance on rand(). It would be great if the functions would take a C++11 random number generator so we could produce a deterministic/reproducible sampling.
include/igl/blue_noise.cpp
Outdated
| // z subscript along z direction | ||
| // Returns index value | ||
| // | ||
| inline BlueNoiseKeyType key( |
Collaborator
There was a problem hiding this comment.
Maybe those functions could be prefixed by blue_noise_? E.g. blue_noise_key, blue_noise_far_enough, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Robert Bridson's "Fast Poisson Disk Sampling in Arbitrary Dimensions" but samples are restricted to be on input triangle mesh. (Euclidean distance is still used).
Also adds a
barycentric_interpolationfunctions (cf. #1596) and corresponding testCheck all that apply (change to
[x])