Skip to content

rm strange function, not in use#1596

Merged
alecjacobson merged 1 commit intomasterfrom
rm-barycentric_to_global
Sep 4, 2020
Merged

rm strange function, not in use#1596
alecjacobson merged 1 commit intomasterfrom
rm-barycentric_to_global

Conversation

@alecjacobson
Copy link
Copy Markdown
Contributor

@alecjacobson alecjacobson commented Aug 23, 2020

This barycentric_to_global function does not appear to be in use. It takes as input an usual packing of triangle ids (indices) and barycentric coordinates (floats) into the same matrix.

We could replace it with a prototype such as barycentric_interpolation(V,F,I,BC), for now just delete because it's not in use.

@alecjacobson alecjacobson mentioned this pull request Aug 23, 2020
Merged
4 tasks
@alecjacobson alecjacobson merged commit b582eca into master Sep 4, 2020
@jdumas jdumas deleted the rm-barycentric_to_global branch September 4, 2020 14:32
@ryanlukejohns
Copy link
Copy Markdown

ryanlukejohns commented Mar 4, 2021 •
edited
Loading

I just noticed this was removed when trying to build using the most recent release. This function is useful in combination with the output of igl::embree::line_mesh_intersection , for example:

// Output: #Vx3 matrix of barycentric coordinates:  id b1 b2.
Eigen::MatrixXd bc = igl::embree::line_mesh_intersection(VP, NP, V, F); 

//convert bc to 3d
Eigen::MatrixXd XP = igl::barycentric_to_global(V, F, bc);

Would this same result be possible with the new barycentric_interpolation? It has some extra inputs I'm not sure I understand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecjacobson @ryanlukejohns