dont use floating point values to index eigen types#1361
Merged
jdumas merged 5 commits intolibigl:masterfrom Apr 11, 2020
Janos95:dev
Merged
dont use floating point values to index eigen types#1361jdumas merged 5 commits intolibigl:masterfrom Janos95:dev
jdumas merged 5 commits intolibigl:masterfrom
Janos95:dev
Conversation
jdumas
approved these changes
Nov 25, 2019
include/igl/flood_fill.cpp
Outdated
| for(int bxi = xi;signed_xi<--bxi;) | ||
| { | ||
| S(bxi+res(0)*(yi + res(1)*zi)) = s; | ||
| S(int(bxi+res(0)*(yi + res(1)*zi))) = s; |
Collaborator
There was a problem hiding this comment.
Here the cast should be on res(0) and res(1) directly.
jdumas
approved these changes
Dec 4, 2019
Collaborator
|
@Janos95 can you rename |
Contributor
Author
|
Sorry, I thought this was already merged so I pushed some other work onto my fork. |
Collaborator
|
Thanks! But I think my comment from last time still applies (about casting only the doubles, not the whole expr). I would have merged it earlier but our current CI is a bit wonky (it often times out and I need to restart it manually). |
Contributor
Author
|
I think I corrected that in 5b996d9 . |
Collaborator
|
5b996d9 only changed one line, but I think the comment applies to other lines as far as I can tell from the PR summary. |
skoch9
pushed a commit
to skoch9/libigl
that referenced
this pull request
Jun 3, 2020
* dont use floating point values to index eigen types * only cast doubles not the whole expression * add remaining casts * Update cast. Co-authored-by: Jérémie Dumas <jeremie.dumas@ens-lyon.org>
jmather-sesi
added a commit
to sideeffects/libigl
that referenced
this pull request
Jun 10, 2022
This resolves an issue in active_set.cpp for newer Eigen versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the corresponding issue, I changed the necessary files so there are no Eigen array accesses using floating point types.
Check all that apply (change to
[x])