Skip to content

Fixes build with mingw-w64#1335

Merged
jdumas merged 8 commits intolibigl:masterfrom
tamasmeszaros:fix-mingw-build
Apr 12, 2020
Merged

Fixes build with mingw-w64#1335
jdumas merged 8 commits intolibigl:masterfrom
tamasmeszaros:fix-mingw-build

Conversation

@tamasmeszaros
Copy link
Copy Markdown
Contributor

Check all that apply (change to [x])

  • [x ] All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • [ x] This is a minor change.

@jdumas jdumas changed the base branch from master to dev October 30, 2019 16:08
@jdumas jdumas changed the base branch from dev to master April 11, 2020 17:05
- [ ] Linux

See <https://libigl.github.io/CONTRIBUTING/#bugreport> for more tips.
See https://libigl.github.io/CONTRIBUTING/#bugreport for more tips.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these changes?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch probably duplicates an old commit. The new version after merged is unchanged.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teseoch can we merge this?

@jdumas jdumas requested a review from teseoch April 11, 2020 20:24
@jdumas jdumas merged commit 651fc23 into libigl:master Apr 12, 2020
skoch9 pushed a commit to skoch9/libigl that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants