Extended serialization functionality to Eigen::Array.#1113
Merged
jdumas merged 2 commits intolibigl:masterfrom Apr 11, 2020
Merged
Extended serialization functionality to Eigen::Array.#1113jdumas merged 2 commits intolibigl:masterfrom
jdumas merged 2 commits intolibigl:masterfrom
Conversation
jdumas
requested changes
Mar 18, 2019
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Yeah, looks like using Eigen::DenseBase for this would make more sense. I almost never use Eigen::Array, apart as temporary to broadcast member-wise operations such as *.
Also, if you want to add some unit tests for serialization, you are more than welcome to do so :D
jdumas
approved these changes
Apr 11, 2020
skoch9
pushed a commit
to skoch9/libigl
that referenced
this pull request
Jun 3, 2020
* Extended serialization functionality to Eigen::Array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the serialization functionality is implemented only for Eigen::Matrix and Eigen::SparseMatrix. This commit duplicates the Eigen::Matrix code for Eigen::Array.
Perhaps Eigen::DenseBase can be used to prevent code repetition.
There do not seem to be any unit tests for the serialization functionality, thus none were added.