git__getenv: utf-8 aware env reader #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Bleh. |
Introduce `git__getenv` which is a UTF-8 aware `getenv` everywhere. Make `cl_getenv` use this to keep consistent memory handling around return values (free everywhere, as opposed to only some platforms).
Member
Author
|
Okay, this is ready for review. This only affects tests so I'm happy to punt on it until 0.23 lands. |
Member
There was a problem hiding this comment.
All of these NULLs are redundant. Static data is initialized to zero. It's not a big deal, but it's a part of the diff that doesn't do anything.
Member
|
Yeah, let's hold off on merging it until after the release. |
carlosmn
added a commit
that referenced
this pull request
Jul 6, 2015
git__getenv: utf-8 aware env reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently,
cl_getenvwrapsgetenvon posixy systems and does some UTF16-UTF8 magic on Windows. The return code must be freed on Windows and must not be on Unix boxes. Ugh.p_getenvjust wrapsgetenvon all systems, which means it's ANSI code page on Windows. (This hasn't really bitten us, yet, as we don't read potentially Unicode values in the library, only in the tests.) But still, ugh again.This introduces
git__getenvwhich is a UTF-8 awaregetenveverywhere. Plus some helpery clar stuff because we can.