Skip to content

reflog: follow core.logallrefupdates#2194

Merged
vmg merged 2 commits intodevelopmentfrom
cmn/reflog-bare
Mar 20, 2014
Merged

reflog: follow core.logallrefupdates#2194
vmg merged 2 commits intodevelopmentfrom
cmn/reflog-bare

Conversation

@carlosmn
Copy link
Copy Markdown
Member

On bare by default, or when core.logallrefupdates is false, we must not
write the reflog.

This fixes #2186 and lets libgit2/libgit2sharp#612 enable more testing.

@nulltoken
Copy link
Copy Markdown
Member

👍

@nulltoken
Copy link
Copy Markdown
Member

Successfully tested against LibGit2Sharp.

:shipit:

nulltoken referenced this pull request in libgit2/libgit2sharp Mar 20, 2014
src/refdb_fs.c Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this int should_write_reflog(bool *write, git_repository *repo, const char *name)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sounds sensible.

On bare by default, or when core.logallrefupdates is false, we must not
write the reflog.
@vmg
Copy link
Copy Markdown
Member

vmg commented Mar 20, 2014

So much better. Thanks @carlosmn!

vmg pushed a commit that referenced this pull request Mar 20, 2014
reflog: follow core.logallrefupdates
@vmg vmg merged commit 7d63357 into development Mar 20, 2014
@nulltoken nulltoken deleted the cmn/reflog-bare branch March 20, 2014 21:13
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cough typo cough

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you see it, now you don't.

phatblat pushed a commit to phatblat/libgit2 that referenced this pull request Sep 13, 2014
reflog: follow core.logallrefupdates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants